Repository navigation
DEV-446: Read Apple sign-in tokens from the URL fragment - #12
Merged
Merged
Conversation
- oauth-callback takes the Apple access and refresh tokens from the URL fragment, which never reaches a server, log or Referer - Falls back to the old ?code=&refresh_token= query, so it works before and after the API switches - Clears the tokens from the address bar and history right away - Stores the Apple refresh token instead of dropping it, so Apple web sessions renew like Google and GitHub ones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the DEV-446 security audit. After Apple web sign-in, the API redirects to
/oauth-callbackwith the access and refresh tokens in the query string, so they end up in browser history and hosting logs.?code=&refresh_token=queryShip this before the API change that moves the tokens to the fragment; it works with the API as it is today.